feat: Added ability to load terraform registry url and credentials fo… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chivalryq
reviewed
Jan 9, 2023
| // Terraform credentials | ||
| TerraformCredentials = "credentials.tfrc.json" | ||
| // Terraform Registry | ||
| TerraformRegistry = "terraformrc" |
There was a problem hiding this comment.
Why the var is named TerraformRegistry?
There was a problem hiding this comment.
the variable in named terraformregistry because the secret contains the details of the custom terraform registry URL we want to connect to.
There was a problem hiding this comment.
But this rc file can contains other configurations too. Only TerraformRegistry is inaccurate.
| needSecretKeys := []string{TerraformRegistry, TerraformCredentials} | ||
| for _, key := range needSecretKeys { | ||
| if _, ok := secret.Data[key]; !ok { | ||
| err := errors.Errorf("'%s' not in git credentials secret", key) |
| terraformCredentialsSecretVolume := corev1.Volume{Name: TerraformCredentialsConfigVolumeName} | ||
| terraformCredentialsSecretVolume.Secret = &corev1.SecretVolumeSource{ | ||
| SecretName: "terraform-credentials", | ||
| DefaultMode: &gitSecretDefaultMode, |
|
Also let's send the PR to https://github.com/kubevela/terraform-controller |
ramekris3163
force-pushed
the
feat/supportprivateterraformregistry
branch
from
62520e5 to
6a1232f
Compare
…rm a kubernetes secret. Signed-off-by: raradhakrishnan <[email protected]>
Signed-off-by: raradhakrishnan <[email protected]>
Signed-off-by: raradhakrishnan <[email protected]>
Signed-off-by: raradhakrishnan <[email protected]>
Signed-off-by: raradhakrishnan <[email protected]>
…tials-helper form configmaps. Signed-off-by: raradhakrishnan <[email protected]>
…ry as per review commments. Signed-off-by: raradhakrishnan <[email protected]>
… or configMap. Review comment fixed. Signed-off-by: raradhakrishnan <[email protected]>
…fixed review comment. Signed-off-by: raradhakrishnan <[email protected]>
…tent for secret and configmaps check. Fixed review comments. Signed-off-by: raradhakrishnan <[email protected]>
Signed-off-by: raradhakrishnan <[email protected]>
Signed-off-by: raradhakrishnan <[email protected]>
Signed-off-by: raradhakrishnan <[email protected]>
Co-authored-by: qiaozp <[email protected]> Signed-off-by: raradhakrishnan <[email protected]>
Co-authored-by: qiaozp <[email protected]> Signed-off-by: raradhakrishnan <[email protected]>
ramekris3163
force-pushed
the
feat/supportprivateterraformregistry
branch
from
6a6cb4c to
5b3fffb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rm a kubernetes secret.