Skip to content

Conversation

Copy link

Copilot AI commented Nov 28, 2025

Summary

Fixes #10135

Adds label-based skip support for the check-plugins-build / validate workflow check, matching the existing pattern used for e2e tests.

Occurred changes and/or fixed issues

  • Added if condition to the validate job in .github/workflows/check-plugins.yaml that checks for ci/skip-validate-plugins label
  • When label is present on a PR, the check is skipped

Technical notes summary

Uses the same pattern as existing ci/skip-e2e label in test.yaml:

if: "!contains( github.event.pull_request.labels.*.name, 'ci/skip-validate-plugins')"

Areas or cases that should be tested

  • Create a PR with ci/skip-validate-plugins label → validate job should be skipped
  • Create a PR without the label → validate job should run normally

Areas which could experience regressions

None - this is an additive change to workflow conditional logic.

Screenshot/Video

N/A - CI workflow change only

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base
Original prompt

This section details on the original issue you should resolve

<issue_title>Allow to skip check-plugins-build / validate check</issue_title>
<issue_description># Description

Allow to skip the check for check-plugins-build / validate using label ci/skip-validate-plugins.

After the episode of multiple failing checks, it seems convenient to have a similar label to omit checks in case of undoubtedly certain issues in the workflow.
</issue_description>

Comments on the Issue (you are @copilot in this section)

@codyrancher Here's an example of workflows using labels for skipping a check https://github.com/rancher/dashboard/blob/master/.github/workflows/scripts/pr-gh-project.js#L275-L278 @cnotv We have the E2E using labels since long https://github.com/rancher/dashboard/blob/master/.github/workflows/test.yaml#L40

Your code seems using env var instead or?</comment_new>
<comment_new>@codyrancher

We have the E2E using labels since long https://github.com/rancher/dashboard/blob/master/.github/workflows/test.yaml#L40

Your code seems using env var instead or?

I'm happy if either is done. The QA_NONE was the label checking I was aware of so I linked it just in case someone takes the issue they won't have to dig into it.</comment_new>


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Allow skipping validate check for plugins Allow to skip check-plugins-build / validate check with ci/skip-validate-plugins label Nov 28, 2025
Copilot AI requested a review from nwmac November 28, 2025 22:54
Copilot finished work on behalf of nwmac November 28, 2025 22:54
@nwmac nwmac added this to the v2.14.0 milestone Nov 28, 2025
@nwmac nwmac marked this pull request as ready for review November 28, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to skip check-plugins-build / validate check

2 participants