Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#766 Consistently using verbs in titles #1038

Merged
merged 34 commits into from
Jan 11, 2024

Conversation

martyav
Copy link
Contributor

@martyav martyav commented Dec 19, 2023

Fixes #766

Reminders

  • See the README for more details on how to work with the Rancher docs.

  • Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.

  • If the pull request is dependent on an upcoming release, make sure to target the release branch instead of main.

Description

This PR goes back and addresses a minor issue that was discussed some weeks ago, about page titles. I used the table in #753 to find pages that needed updating.

Comments

Should we also address pages that have dropdowns in the sidebar, such as https://ranchermanager.docs.rancher.com/pages-for-subheaders/configure-openldap? Notice that the page title has a gerund but the sidebar label does not.

@@ -1,5 +1,5 @@
---
title: Provisioning Drivers
title: About Provisioning Drivers
Copy link
Contributor Author

@martyav martyav Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a special case. The page is about drivers that provision nodes and clusters. It's not about how to provision a node or cluster driver. Since the sidebar label is already 'About Provisioning Drivers' I went with that.

@@ -326,7 +326,7 @@ const sidebars = {
},
{
type: 'category',
label: 'Manage Clusters',
label: 'Cluster Administration',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another special case. The page is titled "Cluster Administration" and isn't a how-to. Instead, it contains a table of actions you can perform on clusters

@martyav
Copy link
Contributor Author

martyav commented Dec 20, 2023

I'm going to pause here since this PR is getting very large

@@ -1,5 +1,5 @@
---
title: Monitoring Guides
title: Monitoring/Alerting Guides
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To match label

@@ -260,11 +260,11 @@
"description": "The label for category Provisioning Storage Examples in sidebar tutorialSidebar"
},
"sidebar.tutorialSidebar.category.Manage Projects": {
"message": "Manage Projects",
"message": "Project Administration",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To match title, and to match the label in new user guides, "Cluster Administration"

"description": "The label for category Manage Projects in sidebar tutorialSidebar"
},
"sidebar.tutorialSidebar.category.Manage Project Resource Quotas": {
"message": "Manage Project Resource Quotas",
"message": "Project Resource Quotas",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed verb as it isn't really a how-to

"description": "The label for category Launch Kubernetes with Rancher in sidebar tutorialSidebar"
},
"sidebar.tutorialSidebar.category.Use New Nodes in an Infra Provider": {
"message": "Use New Nodes in an Infra Provider",
"message": "Launching New Nodes in an Infra Provider",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual title of this page is so long that I compromised with a shorter version that at least starts with the same word as the title

@btat
Copy link
Contributor

btat commented Dec 21, 2023

@martyav is this ready for review now? There were a number of commits made after the previous review request.

@martyav
Copy link
Contributor Author

martyav commented Dec 26, 2023

@btat Yep, not adding anything more except if suggested. When I left off last, I had finished going through the Getting Started and How-to guides. I don't intend to go over other sections at this time

Copy link
Contributor

@sunilarjun sunilarjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

Copy link
Contributor Author

@martyav martyav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consistent page titles across versions

@martyav martyav merged commit 3a4b7e7 into rancher:main Jan 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistently using verbs in titles
3 participants