-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eks cluster configuration #1048
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
martyav
suggested changes
Dec 29, 2023
...rence-guides/cluster-configuration/rancher-server-configuration/eks-cluster-configuration.md
Outdated
Show resolved
Hide resolved
...rence-guides/cluster-configuration/rancher-server-configuration/eks-cluster-configuration.md
Outdated
Show resolved
Hide resolved
...rence-guides/cluster-configuration/rancher-server-configuration/eks-cluster-configuration.md
Outdated
Show resolved
Hide resolved
richardcase
reviewed
Jan 16, 2024
...rence-guides/cluster-configuration/rancher-server-configuration/eks-cluster-configuration.md
Show resolved
Hide resolved
Issue: rancher/eks-operator#301 Update eks cluster configuration with section about: - Launching self-managed Amazon Linux nodes - IAM roles for service accounts
ffa21b1
to
99d6c3f
Compare
richardcase
approved these changes
Jan 17, 2024
martyav
suggested changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor things -- adding links, changing the ordered list syntax, and a request to clarify the note.
...rence-guides/cluster-configuration/rancher-server-configuration/eks-cluster-configuration.md
Outdated
Show resolved
Hide resolved
...rence-guides/cluster-configuration/rancher-server-configuration/eks-cluster-configuration.md
Outdated
Show resolved
Hide resolved
...rence-guides/cluster-configuration/rancher-server-configuration/eks-cluster-configuration.md
Outdated
Show resolved
Hide resolved
martyav
suggested changes
Feb 28, 2024
...rence-guides/cluster-configuration/rancher-server-configuration/eks-cluster-configuration.md
Outdated
Show resolved
Hide resolved
...rence-guides/cluster-configuration/rancher-server-configuration/eks-cluster-configuration.md
Outdated
Show resolved
Hide resolved
martyav
reviewed
Mar 5, 2024
...rence-guides/cluster-configuration/rancher-server-configuration/eks-cluster-configuration.md
Outdated
Show resolved
Hide resolved
martyav
approved these changes
Mar 7, 2024
This had been tied to a release and should have gone out in late January |
Related issue was merged on Jan 26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
DO NOT MERGE
next-release
This PR is tied to the next Rancher release and should take higher priority
sync-versions
Reminder to sync versioned pages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/eks-operator#301
Update eks cluster configuration with section about:
Fixes #rancher/eks-operator#301
Reminders
See the README for more details on how to work with the Rancher docs.
Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.
If the pull request is dependent on an upcoming release, make sure to target the release branch instead of
main
.Description
Comments