Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eks cluster configuration #1048

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Conversation

mjura
Copy link
Contributor

@mjura mjura commented Dec 28, 2023

Issue: rancher/eks-operator#301

Update eks cluster configuration with section about:

  • Launching self-managed Amazon Linux nodes
  • IAM roles for service accounts

Fixes #rancher/eks-operator#301

Reminders

  • See the README for more details on how to work with the Rancher docs.

  • Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.

  • If the pull request is dependent on an upcoming release, make sure to target the release branch instead of main.

Description

Comments

@btat btat added DO NOT MERGE next-release This PR is tied to the next Rancher release and should take higher priority labels Jan 9, 2024
Issue: rancher/eks-operator#301

Update eks cluster configuration with section about:
- Launching self-managed Amazon Linux nodes
- IAM roles for service accounts
@mjura mjura force-pushed the eks-cluster-conf-update branch from ffa21b1 to 99d6c3f Compare January 17, 2024 10:23
@mjura mjura requested review from richardcase and martyav January 17, 2024 10:26
Copy link
Contributor

@martyav martyav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things -- adding links, changing the ordered list syntax, and a request to clarify the note.

@martyav martyav added the sync-versions Reminder to sync versioned pages label Feb 23, 2024
@martyav martyav merged commit 0e76fd2 into rancher:main Mar 7, 2024
1 check passed
@martyav
Copy link
Contributor

martyav commented Mar 7, 2024

This had been tied to a release and should have gone out in late January

@martyav
Copy link
Contributor

martyav commented Mar 7, 2024

Related issue was merged on Jan 26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE next-release This PR is tied to the next Rancher release and should take higher priority sync-versions Reminder to sync versioned pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants