-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CNI popularity table for 2.8.1 #1071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke tested and all tables loaded successfully across versions.
Test deployment failed with heap allocation error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion for style
I've reran the build a couple times it and it's failing each time because of heap allocation, but the other PRs I submitted in the same time period built without issues. I want to see if different PRs that might get pushed today have the same issue before bumping the allocation size again. |
This is now waiting on #1076. |
Co-authored-by: Marty Hernandez Avedon <[email protected]>
c4ac54c
to
964b481
Compare
Related to #1069
Description
Updates the table with the current counts as of 2.8.1 release.
Additionally, I've moved the table into a partial under a top-level shared-files directory since the table is the same for all versions. This allows us to only maintain one copy of the content.