Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CNI popularity table for 2.8.1 #1071

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Conversation

btat
Copy link
Contributor

@btat btat commented Jan 17, 2024

Related to #1069

Description

Updates the table with the current counts as of 2.8.1 release.

Additionally, I've moved the table into a partial under a top-level shared-files directory since the table is the same for all versions. This allows us to only maintain one copy of the content.

@btat btat mentioned this pull request Jan 17, 2024
5 tasks
@btat btat added the MERGE ON RELEASE Don't merge until the moment the next release publishes label Jan 18, 2024
Copy link
Contributor

@sunilarjun sunilarjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested and all tables loaded successfully across versions.

@martyav
Copy link
Contributor

martyav commented Jan 18, 2024

Test deployment failed with heap allocation error

Copy link
Contributor

@martyav martyav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion for style

@btat
Copy link
Contributor Author

btat commented Jan 18, 2024

Test deployment failed with heap allocation error

I've reran the build a couple times it and it's failing each time because of heap allocation, but the other PRs I submitted in the same time period built without issues. I want to see if different PRs that might get pushed today have the same issue before bumping the allocation size again.

@btat
Copy link
Contributor Author

btat commented Jan 22, 2024

This is now waiting on #1076.

@btat btat force-pushed the 2.8.1-cni-popularirty branch from c4ac54c to 964b481 Compare January 22, 2024 23:36
@btat btat merged commit fe36697 into rancher:main Jan 22, 2024
1 check passed
@btat btat deleted the 2.8.1-cni-popularirty branch January 23, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MERGE ON RELEASE Don't merge until the moment the next release publishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants