Add vsphere user-data.iso cleanup note #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakefhyde
requested review from
btat,
LucasSaintarbor and
sunilarjun
as code owners
Oats87
approved these changes
Jan 3, 2025
Oats87
previously approved these changes
Jan 7, 2025
There was a problem hiding this comment.
@jakefhyde Made some changes based on the SUSE Style guide. Lmk if these changes are okay. Thanks!
...ncher/use-new-nodes-in-an-infra-provider/vsphere/provision-kubernetes-clusters-in-vsphere.md
Outdated
Show resolved
Hide resolved
…her/use-new-nodes-in-an-infra-provider/vsphere/provision-kubernetes-clusters-in-vsphere.md Co-authored-by: Lucas Saintarbor <[email protected]>
… v2.11 docs Signed-off-by: LucasSaintarbor <[email protected]>
LucasSaintarbor
force-pushed
the
1535-vsphere-cleanup
branch
from
dad9c0a to
3df3c4c
Compare
LucasSaintarbor
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
@jakefhyde LGTM. Rebased your branch and added the note to v2.8, v2.9, v2.10, v2.11 docs.
jiaqiluo
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1535
Reminders
See the README for more details on how to work with the Rancher docs.
Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.
If the pull request is dependent on an upcoming release, remember to add a "MERGE ON RELEASE" label and set the proper milestone.
Description
Add warning on cleanu of
user-data.isos as per SURE-6985.Comments