Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding rancher-istio deprecation notice #1627

Merged
merged 2 commits into from
Feb 19, 2025
Merged

adding rancher-istio deprecation notice #1627

merged 2 commits into from
Feb 19, 2025

Conversation

diogoasouza
Copy link
Contributor

Rancher-istio will be deprecated according to the following timeline:

  • Rancher 2.11: Deprecation announcement
  • Rancher 2.12: Deprecation configuration
  • Rancher 2.13: Removed

recena
recena reviewed Jan 31, 2025
View reviewed changes
docs/how-to-guides/advanced-user-guides/istio-setup-guide/istio-setup-guide.md Outdated
@@ -6,6 +6,12 @@ title: Istio Setup Guides
<link rel="canonical" href="https://ranchermanager.docs.rancher.com/how-to-guides/advanced-user-guides/istio-setup-guide"/>
</head>

:::note

[Rancher-Istio](https://github.com/rancher/istio-installer) will be deprecated in upcoming Rancher releases; turn to the Application Collection build of Istio for enhanced security (included in SUSE Rancher Prime subscriptions).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we point out to https://github.com/rancher/charts/tree/dev-v2.10/charts/rancher-istio?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can, I just pointed out to the installer because that's what in the approved text

recena
recena reviewed Jan 31, 2025
View reviewed changes
docs/how-to-guides/advanced-user-guides/istio-setup-guide/istio-setup-guide.md Outdated
@@ -6,6 +6,12 @@ title: Istio Setup Guides
<link rel="canonical" href="https://ranchermanager.docs.rancher.com/how-to-guides/advanced-user-guides/istio-setup-guide"/>
</head>

:::note

[Rancher-Istio](https://github.com/rancher/istio-installer) will be deprecated in upcoming Rancher releases; turn to the Application Collection build of Istio for enhanced security (included in SUSE Rancher Prime subscriptions).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Rancher-Istio](https://github.com/rancher/istio-installer) will be deprecated in upcoming Rancher releases; turn to the Application Collection build of Istio for enhanced security (included in SUSE Rancher Prime subscriptions).
[Rancher-Istio](https://github.com/rancher/istio-installer) will be deprecated in upcoming Rancher releases; turn to the [SUSE Rancher Application Collection](https://apps.rancher.io) build of Istio for enhanced security (included in SUSE Rancher Prime subscriptions).
Detailed information can be found in [this announcement](https://forums.rancher.com/t/deprecation-of-rancher-istio/45043/1).

@diogoasouza diogoasouza force-pushed the istio-deprecation-notice branch 2 times, most recently from f565256 to f5b1630 Compare January 31, 2025 00:18
@recena
Copy link

recena commented Jan 31, 2025

⚠️ This information must be included in the Release Notes.

@Jono-SUSE-Rancher Jono-SUSE-Rancher added the release-note Note this issue in the milestone's release notes label Jan 31, 2025
@btat btat changed the base branch from main to v2.11.0 January 31, 2025 21:25
@btat
Copy link
Contributor

btat commented Jan 31, 2025 •
edited
Loading

@recena I couldn't find an issue on rancher/rancher for the deprecation, is there one? If so, and it has the release-note label we'd pick it up during our usual curation process. If not, I can create a separate issue in this repo so it doesn't get lost when this PR gets merged.

Side note, this needs to be applied against the directory for 2.11 files, but we (Docs team) haven't created the 2.11 file structure yet. When that's done we can move this PR along.

@recena
Copy link

recena commented Feb 13, 2025

@btat Discussed offline.

@btat btat deleted the branch rancher:v2.11.0 February 18, 2025 23:36
@btat btat closed this Feb 18, 2025
@btat btat reopened this Feb 19, 2025
@btat btat added this to the v2.11.0 milestone Feb 19, 2025
@LucasSaintarbor LucasSaintarbor force-pushed the istio-deprecation-notice branch from f5b1630 to 9546964 Compare February 19, 2025 18:38
LucasSaintarbor
LucasSaintarbor approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diogoasouza Just a heads up, rebased your branch to add the changes to the v2.11 directory.

@LucasSaintarbor LucasSaintarbor merged commit b457c9e into rancher:v2.11.0 Feb 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@recena recena recena approved these changes

@rohitsakala rohitsakala rohitsakala approved these changes

@sunilarjun sunilarjun sunilarjun approved these changes

@LucasSaintarbor LucasSaintarbor LucasSaintarbor approved these changes

@btat btat Awaiting requested review from btat btat is a code owner

Assignees
No one assigned
Labels
release-note Note this issue in the milestone's release notes
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.
7 participants
@diogoasouza @recena @btat @rohitsakala @sunilarjun @LucasSaintarbor @Jono-SUSE-Rancher