Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update field names and nav paths to reflect changes in newer Keycloak… #1641

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

btat
Copy link
Contributor

@btat btat commented Feb 12, 2025

SURE-9548

Fixes #1114, fixes #1176

Description

Keycloak, including its docs, has undergone many revisions (e.g. new UI, migrated to Quarkus), which has caused a disconnect between what's indicated mentioned in our docs and what's in recent versions of Keycloak.

This PR updates references fields and navigation paths to sync with current versions (25/26) of Keycloak. Our existing docs list certain fields and their expected values, but newer Keycloak versions have additional fields (e.g. lightweight access token and Add to token introspection for the Group membership mapper type). Per engineering, these aren't used and can be left with the default value.

I also opted to list out explicit Keycloak steps as I either couldn't find any relevant links or if linkable steps were present it needed additional context as the relevant steps were interwoven with other content.

@btat btat requested a review from sunilarjun as a code owner February 12, 2025 21:23
Copy link
Contributor

@sunilarjun sunilarjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested per version/translation and the changes look good, thanks for updating Billy! Approved

@btat btat merged commit ab360c4 into rancher:main Feb 13, 2025
1 check passed
@btat btat deleted the sure-9548-keycloak branch February 13, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve OIDC / Rancher/Keycloak docs Keycloak related docs are outdated
2 participants