-
Notifications
You must be signed in to change notification settings - Fork 245
Add Tokens example workflows page #1839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tokens example workflows page #1839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @andreas-kupries thank you for the page addition! I've left some review comments addressing some style/contents, and also are you able to rebase and add these changes to the v2.12 versioned_docs folder?
Additionally, the sidebars.js and versioned_sidebars/version-2.12-sidebars.json files need to be updated in order for the page to display and be clickable from the left navigation. Essentially "api/workflows/tokens"
needs to be added to the sidebars.js file at line 1360, and similarly in the versioned_sidebars/version-2.12-sidebars.json file.
Please let me know if you need any help and I can definitely assist in updating the sidebars files as well, thanks!
0d692bf
to
4cd310a
Compare
Accepted.
Rebased to main now, and done the 2.12 changes, including the sidebars mentioned below. Commit 4cd310a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving wrt my changes being addressed, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreas-kupries Requesting some grammar/style changes. Thanks!
996797c
to
b1633cb
Compare
Latest comments addressed. Also rebased to resolve conflict with kubeconfig work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreas-kupries Thanks for applying the changes! LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreas-kupries Should not have approved just yet, to clean up the commit history, may you rebase against the https://github.com/rancher/rancher-docs/tree/v2.12.0
branch instead of main?
Co-authored-by: Petr Kovar <[email protected]>
Co-authored-by: Peter Matseykanets <[email protected]>
Co-authored-by: Sunil Singh <[email protected]>
Thanks for the review and corrections. Co-authored-by: Lucas Saintarbor <[email protected]>
Co-authored-by: Lucas Saintarbor <[email protected]>
b1633cb
to
a5ddef9
Compare
@andreas-kupries No need to rebase @btat took care of it. |
After first reading the above I thought that I had rebased to 2.12 in my latest push. |
Fixes #1630
Reminders
See the README for more details on how to work with the Rancher docs.
Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.
If the pull request is dependent on an upcoming release, remember to add a "MERGE ON RELEASE" label and set the proper milestone.
Description
Add an example workflows page for the new Imperative API resource Tokens that is coming with Rancher v2.12.0.
Comments