Clarify the expected format of NO_PROXY
#1841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarrisonWAffel
requested review from
btat,
LucasSaintarbor,
pmkovar and
sunilarjun
as code owners
HarrisonWAffel
force-pushed
the
clarify-no-proxy-value
branch
from
a5b0e42 to
1f1f154
Compare
btat
force-pushed
the
clarify-no-proxy-value
branch
from
1f1f154 to
717bef1
Compare
btat
approved these changes
Jul 21, 2025
sunilarjun
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#50041
Description
The current documentation doesn't state the expected format of the
NO_PROXYenvironment variable. While there are several examples which follow the same format,NO_PROXYis not a standardized environment variable and users may be under the impression that various value formats will work, which is not the case.For instance, other SUSE documentation states that white space can be used as a delimiter. However doing this in Rancher will result in subtle issues that are difficult to debug.
This PR adds a clear explanation of the format of
NO_PROXYwhich is accepted by Rancher (and actively tested) to several sections of the documentation that already mentionNO_PROXY. The explanation includes a link to the official Golang docs which has a full description of the accepted format.Comments
Let me know if I should remove the link to the upstream Go documentation in favor of an additional page in the docs repo or some other approach. I'm not 100% clear on this repo's policy on linking to external resources / documentation.