[main] Allow webhook pods to have leader election to govern which pod updates the config #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobby
changed the title
crobby
force-pushed
the
hawebhook
branch
2 times, most recently
from
73a76e2 to
efca921
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#43525
Problem
Rancher webhook isn't optimized to run in an HA configuration
Solution
With this PR, rancher-webhook now performs a leader election at startup time and the configuration will be managed only by the leader pod, follower pods will not attempt to update the webhook configurations.
Note, this PR does not change the default installation of rancher-webhook. In order to take advantage of this, you would need to modify the replicas for rancher-webhook in the deployment or manually scale the webhook at runtime.
This PR just prevents multiple copies of rancher-webhook from constantly attempting to update configuration with the same information.