Skip to content

Remove usage of golang.org/x/exp #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

Remove usage of golang.org/x/exp #706

merged 1 commit into from
Mar 18, 2025

Conversation

@rohitsakala
Copy link
Member

Issue #677

golang.org/x/exp/slices uses slices indirectly 😄

@rohitsakala rohitsakala requested a review from a team as a code owner February 20, 2025 22:36
@rohitsakala rohitsakala removed the request for review from a team February 20, 2025 22:36
ericpromislow
ericpromislow approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but the same comment: please use more descriptive branch names that don't conflict with existing branches in the parent. I usually start mine with the issue number.

@rohitsakala rohitsakala merged commit 5022809 into rancher:release/v0.6 Mar 18, 2025
2 checks passed
@rohitsakala rohitsakala deleted the release/v0.6 branch March 18, 2025 00:52
This was referenced Mar 24, 2025
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericpromislow ericpromislow ericpromislow approved these changes

@joshmeranda joshmeranda joshmeranda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rohitsakala @ericpromislow @joshmeranda