fix: debug nudge phantom turn loop - #278
Open
ranxianglei wants to merge 1 commit into
Open
Conversation
…r debug notifications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
config.debug: true, ACP's debug notifications usedsendIgnoredMessage()to persist nudge text and compress notifications to the conversation DB asignored: trueuser messages. opencode's runtime loop detects the last user message byrole == "user"WITHOUT checking theignoredflag, so the phantom user message triggers a new turn → model keeps working → calls compress → another notification → infinite loop.Reported in issue #20 floor 1734.
Fix
Removed ALL
sendIgnoredMessagecalls from debug-mode notification paths:lib/hooks.ts(debug nudge callback): RemovedsendIgnoredMessage, keptlogger.debug+showToastlib/ui/notification.ts(debug compress notification): ReplacedsendIgnoredMessagewithlogger.debug, keptshowToastBoth sites now use
logger.debug(file log) +showToast(popup) for debug visibility, without writing to the conversation DB.Verification
~/.cache/opencode/packages/opencode-acp@latest/