fix: harden deployment scripts for security#698
Open
simple-agent-manager[bot] wants to merge 1 commit intomainfrom
Open
fix: harden deployment scripts for security#698simple-agent-manager[bot] wants to merge 1 commit intomainfrom
simple-agent-manager[bot] wants to merge 1 commit intomainfrom
Conversation
…osure - configure-secrets.sh: use printf instead of echo to prevent expansion of special chars in PEM keys - configure-r2-cors.sh: use mktemp with cleanup trap instead of world-readable /tmp file - sync-wrangler-config.ts: use execFileSync to prevent shell injection via PULUMI_STACK - run-migrations.ts: use execFileSync to prevent shell injection via db.name - setup-local-dev.ts: replace error:any with proper types, log swallowed errors - verify-pages-domain.sh: replace python3 dependency with jq for consistency - setup-github.ts: fix shebang to match all other scripts (tsx, not npx tsx) Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
echo "$secret_value"withprintf '%s' "$secret_value"to prevent expansion of special characters in PEM keys and hide values from process listings/tmp/r2-cors-response.txtwithmktemp+ cleanup trap to avoid world-readable temp filesexecSyncshell string withexecFileSyncarray args to prevent shell injection viaPULUMI_STACKexecSyncshell string withexecFileSyncarray args to prevent shell injection viadb.nameerror: any,(db: any),(ns: any)with proper types; log swallowed errors instead of empty catch blockspython3 -c "import json..."withjqequivalents, matching every other script in the repo#!/usr/bin/env npx tsxto#!/usr/bin/env tsxfor consistencyTest plan
pnpm lintpasses (0 errors)pnpm typecheckpasses🤖 Generated with Claude Code