Skip to content

fix: resolve profiles list mobile layout overflow #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simple-agent-manager merged 5 commits into from
May 1, 2026
Merged

fix: resolve profiles list mobile layout overflow #869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
94eeb61
task: move fix-profiles-mobile-layout to active
raphaeltm May 1, 2026
c9beaf9
fix: resolve profiles list mobile layout overflow
raphaeltm May 1, 2026
d5a6f64
task: archive profiles mobile layout fix task
raphaeltm May 1, 2026
6e04e41
fix: strengthen error state test assertion and update task file
raphaeltm May 1, 2026
9a4dafb
fix: add focus-visible rings to profile action buttons
raphaeltm May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 57 additions & 52 deletions apps/web/src/components/agent-profiles/ProfileList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { AgentProfile, CreateAgentProfileRequest, UpdateAgentProfileRequest } from '@simple-agent-manager/shared';
import { Button, Spinner } from '@simple-agent-manager/ui';
import { Bot,Pencil, Plus, Trash2 } from 'lucide-react';
import { Bot, Pencil, Plus, Trash2 } from 'lucide-react';
import { type FC, useState } from 'react';

import { ProfileFormDialog } from './ProfileFormDialog';
Expand Down Expand Up @@ -104,70 +104,75 @@ export const ProfileList: FC<ProfileListProps> = ({
{profiles.map((profile) => (
<div
key={profile.id}
className="flex items-start gap-3 p-3 rounded-md border border-border-default bg-page"
className="overflow-hidden rounded-md border border-border-default bg-page"
>
<div className="flex-1 min-w-0">
<div className="flex items-center gap-2">
<span className="text-sm font-medium text-fg-primary truncate">
{profile.name}
</span>
{profile.isBuiltin && (
<span className="shrink-0 px-1.5 py-0.5 text-[10px] font-medium rounded bg-surface border border-border-default text-fg-muted">
built-in
<div className="flex items-start gap-3 p-3">
<div className="flex-1 min-w-0">
<div className="flex items-center gap-2 min-w-0">
<span className="text-sm font-medium text-fg-primary truncate">
{profile.name}
</span>
{profile.isBuiltin && (
<span className="shrink-0 px-1.5 py-0.5 text-[10px] font-medium rounded bg-surface border border-border-default text-fg-muted">
built-in
</span>
)}
</div>
{profile.description && (
<p className="text-xs text-fg-muted mt-0.5 line-clamp-2">{profile.description}</p>
)}
<div className="flex flex-wrap gap-x-3 gap-y-1 mt-1.5 text-xs text-fg-muted">
<span>{profile.agentType}</span>
{profile.model && <span>{profile.model}</span>}
{profile.permissionMode && <span>{profile.permissionMode}</span>}
{profile.vmSizeOverride && <span>VM: {profile.vmSizeOverride}</span>}
{profile.taskMode && <span>Mode: {profile.taskMode}</span>}
</div>
</div>
{profile.description && (
<p className="text-xs text-fg-muted mt-0.5 truncate">{profile.description}</p>
)}
<div className="flex flex-wrap gap-x-3 gap-y-1 mt-1.5 text-xs text-fg-muted">
<span>{profile.agentType}</span>
{profile.model && <span>{profile.model}</span>}
{profile.permissionMode && <span>{profile.permissionMode}</span>}
{profile.vmSizeOverride && <span>VM: {profile.vmSizeOverride}</span>}
{profile.taskMode && <span>Mode: {profile.taskMode}</span>}
</div>
</div>

<div className="flex items-center gap-1 shrink-0">
<button
type="button"
onClick={() => handleEdit(profile)}
aria-label={`Edit ${profile.name}`}
className="p-2 min-w-[44px] min-h-[44px] flex items-center justify-center rounded text-fg-muted hover:text-fg-primary hover:bg-surface cursor-pointer"
>
<Pencil className="w-4 h-4" />
</button>
{deleteConfirmId === profile.id ? (
<div className="flex items-center gap-1">
<button
type="button"
onClick={() => void handleDelete(profile.id)}
aria-label={`Confirm delete ${profile.name}`}
className="px-3 py-2 min-h-[44px] rounded text-xs text-danger bg-danger-tint hover:bg-danger hover:text-white cursor-pointer"
>
Confirm
</button>
<div className="flex items-center gap-1 shrink-0">
<button
type="button"
onClick={() => handleEdit(profile)}
aria-label={`Edit ${profile.name}`}
className="p-2 min-w-[44px] min-h-[44px] flex items-center justify-center rounded text-fg-muted hover:text-fg-primary hover:bg-surface cursor-pointer focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-1 focus-visible:outline-focus-ring"
>
<Pencil className="w-4 h-4" />
</button>
{deleteConfirmId !== profile.id && (
<button
type="button"
onClick={() => { setDeleteConfirmId(null); setDeleteError(null); }}
aria-label="Cancel delete"
className="px-3 py-2 min-h-[44px] rounded text-xs text-fg-muted hover:text-fg-primary cursor-pointer"
onClick={() => { setDeleteConfirmId(profile.id); setDeleteError(null); }}
aria-label={`Delete ${profile.name}`}
className="p-2 min-w-[44px] min-h-[44px] flex items-center justify-center rounded text-fg-muted hover:text-danger hover:bg-danger-tint cursor-pointer focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-1 focus-visible:outline-focus-ring"
>
Cancel
<Trash2 className="w-4 h-4" />
</button>
</div>
) : (
)}
</div>
</div>

{deleteConfirmId === profile.id && (
<div className="flex items-center justify-end gap-2 px-3 pb-3">
<span className="text-xs text-fg-muted mr-auto">Delete this profile?</span>
<button
type="button"
onClick={() => { setDeleteConfirmId(profile.id); setDeleteError(null); }}
aria-label={`Delete ${profile.name}`}
className="p-2 min-w-[44px] min-h-[44px] flex items-center justify-center rounded text-fg-muted hover:text-danger hover:bg-danger-tint cursor-pointer"
onClick={() => { setDeleteConfirmId(null); setDeleteError(null); }}
aria-label="Cancel delete"
className="px-3 py-2 min-w-[44px] min-h-[44px] rounded text-xs text-fg-muted hover:text-fg-primary cursor-pointer focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-1 focus-visible:outline-focus-ring"
>
<Trash2 className="w-4 h-4" />
Cancel
</button>
)}
</div>
<button
type="button"
onClick={() => void handleDelete(profile.id)}
aria-label={`Confirm delete ${profile.name}`}
className="px-3 py-2 min-h-[44px] rounded text-xs text-danger bg-danger-tint hover:bg-danger hover:text-white cursor-pointer focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-1 focus-visible:outline-focus-ring"
>
Confirm
</button>
</div>
)}
</div>
))}
</div>
Expand Down
Loading
Loading