Skip to content

fix: align useChatWebSocket test with 2-param onCatchUp contract#899

Merged
simple-agent-manager[bot] merged 3 commits intomainfrom
fix/oncatchup-test-param
May 5, 2026
Merged

fix: align useChatWebSocket test with 2-param onCatchUp contract#899
simple-agent-manager[bot] merged 3 commits intomainfrom
fix/oncatchup-test-param

Conversation

@simple-agent-manager
Copy link
Copy Markdown
Contributor

@simple-agent-manager simple-agent-manager Bot commented May 5, 2026

Summary

One-line fix for CI failure after PR #898. The useChatWebSocket.behavioral.test.ts test still expected onCatchUp to be called with 3 arguments (including hasMore), but #898 simplified the contract to 2 params. This removes the stale false assertion.

Test plan

  • useChatWebSocket.behavioral.test.ts — all 31 tests pass

Staging Verification

N/A: test-only change, no runtime behavior affected. Staging was verified for parent PR #898.

Agent Preflight (Required)

  • Preflight completed before code changes

Classification

  • external-api-change
  • cross-component-change
  • business-logic-change
  • public-surface-change
  • docs-sync-change
  • security-sensitive-change
  • ui-change
  • infra-change

External References

N/A: test-only assertion alignment with already-merged code behavior.

Codebase Impact Analysis

  • apps/web/tests/unit/hooks/useChatWebSocket.behavioral.test.ts removes the obsolete third-argument expectation from the catch-up callback assertion.

Documentation & Specs

N/A: no user-facing behavior or docs changed; this only aligns a stale test with the existing two-parameter callback contract.

Constitution & Risk Check

Checked Principle XI: no constants, URLs, limits, or configuration values changed. Risk is low because this is a one-line test-only fix.

Specialist Review Evidence

Reviewer Status Outcome
N/A PASS One-line test-only assertion update; no runtime, UI, security, Cloudflare, or Go code changed.

Co-Authored-By: Claude Opus 4.6 [email protected]

raphaeltm and others added 3 commits May 5, 2026 06:34
PR #898 simplified onCatchUp from 3 params to 2 (removed hasMore),
but this behavioral test was missed. Aligns the test expectation.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 5, 2026

@simple-agent-manager simple-agent-manager Bot merged commit 3c39d53 into main May 5, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant