fix: align useChatWebSocket test with 2-param onCatchUp contract#899
Merged
simple-agent-manager[bot] merged 3 commits intomainfrom May 5, 2026
Merged
fix: align useChatWebSocket test with 2-param onCatchUp contract#899simple-agent-manager[bot] merged 3 commits intomainfrom
simple-agent-manager[bot] merged 3 commits intomainfrom
Conversation
PR #898 simplified onCatchUp from 3 params to 2 (removed hasMore), but this behavioral test was missed. Aligns the test expectation. Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
One-line fix for CI failure after PR #898. The
useChatWebSocket.behavioral.test.tstest still expectedonCatchUpto be called with 3 arguments (includinghasMore), but #898 simplified the contract to 2 params. This removes the stalefalseassertion.Test plan
useChatWebSocket.behavioral.test.ts— all 31 tests passStaging Verification
N/A: test-only change, no runtime behavior affected. Staging was verified for parent PR #898.
Agent Preflight (Required)
Classification
External References
N/A: test-only assertion alignment with already-merged code behavior.
Codebase Impact Analysis
apps/web/tests/unit/hooks/useChatWebSocket.behavioral.test.tsremoves the obsolete third-argument expectation from the catch-up callback assertion.Documentation & Specs
N/A: no user-facing behavior or docs changed; this only aligns a stale test with the existing two-parameter callback contract.
Constitution & Risk Check
Checked Principle XI: no constants, URLs, limits, or configuration values changed. Risk is low because this is a one-line test-only fix.
Specialist Review Evidence
Co-Authored-By: Claude Opus 4.6 [email protected]