Skip to content

Feature/datadog support #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lrascao wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feature/datadog support #2

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6efb2d9
Support Datadog tag format
lrascao May 14, 2017
39e93d4
Tolerate histogram datadog metrics
lrascao May 14, 2017
afe0c1f
Fix sample rate format
lrascao Mar 12, 2018
7b3267d
Print unknown statsd messages
lrascao Mar 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 27 additions & 8 deletions statsd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,13 +143,21 @@ func parseLineToQueue(line string, rip net.Addr) {
if bar2 != -1 {
typeEnd = bar1 + 1 + bar2
rest := line[bar1+1+bar2+1:]
if len(rest) < 2 || rest[0] != '@' {
log.Printf("bad line [%s] from ip [%v]", line, rip)
return
}
if sampleRate, err = strconv.ParseFloat(rest[1:], 64); err != nil {
log.Printf("bad line [%s] from ip [%v]", line, rip)
return
// sampling format
if rest[0] == '@' {
sampleEnd := strings.Index(rest[0:], "|")
if sampleRate, err = strconv.ParseFloat(rest[1:sampleEnd], 64); err != nil {
log.Printf("bad line [%s] from ip [%v], err: %s", line, rip, err)
return
}
} else if rest[0] == '#' {
// tag format
// TODO: do something with the tags, now simply tolerate them
// tags := rest[1:]
// log.Printf("tags: %s", tags)
} else {
log.Printf("bad line [%s] from ip [%v]", line, rip)
return
}
}

Expand Down Expand Up @@ -195,8 +203,19 @@ func parseLineToQueue(line string, rip net.Addr) {
//log.Printf("set: %s=%s", line[0:colon], value)
op.op = SDOP_S
op.sval = value
case "h":
// log.Printf("histogram: %s=%s", line[0:colon], value)
ival, err := strconv.ParseInt(value, 10, 64)
if err != nil {
log.Printf("bad line [%s] from ip [%v]", line, rip)
return
}
// TODO: properly support histogram counters
// http://docs.datadoghq.com/guides/metrics/#histograms
op.op = SDOP_G_SET
op.ival = ival
default:
log.Printf("bad line [%s] from ip [%v]", line, rip)
log.Printf("bad line [%s] from ip [%v], unknown %s", line, rip, line[bar1 + 1 : typeEnd])
return
}

Expand Down