document why and when --no-build-isolation is used in wheel-building CI #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
DO NOT MERGE
jameslamb
requested review from
msarahan,
trxcllnt,
vyasr,
bdice,
KyleFromNVIDIA and
robertmaynard
vyasr
requested changes
Oct 24, 2024
Co-authored-by: Vyas Ramasubramani <[email protected]>
jameslamb
changed the title
|
Given the discussion in #108 (comment), there's now just one more project to be migrated to using I'll leave it up for the rest of the day, to give others a chance to comment, then merge it tomorrow if there are no other comments. |
bdice
approved these changes
Oct 29, 2024
Co-authored-by: Bradley Dice <[email protected]>
|
Thank you both for the reviews! Seeing no other comments, I'm going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #108
--no-build-isolationis used in wheel-building CIrapids-build-backend-now😀 )pre-commitconfig, to fix file endings and trailing whitespaceNotes for Reviewers
I've marked this
DO NOT MERGEbecause it's describing as current state changes that haven't actually been made yet... it shouldn't be merged until most of #108 is done.But it's ready for review.