-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically set version in RAPIDS doc builds #15101
Conversation
e378dd9
to
3789e66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete this line as well:
cudf/ci/release/update-version.sh
Line 111 in 4ce99af
sed_runner "s/RAPIDS_VERSION_NUMBER=\".*/RAPIDS_VERSION_NUMBER=\"${NEXT_SHORT_TAG}\"/g" ci/build_docs.sh |
Any time a hard-coded version is adjusted, the update-version.sh
script should be checked.
/merge |
Matches later usages of the same variable name.
This broke our docs uploads. Our documentation bucket now contains a list of folders that looks like this:
cc: @raydouglass |
Thanks AJ! 🙏 Addressing with PR: #15291 |
Prompted by #15101 (comment) Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Ray Douglass (https://github.com/raydouglass) - AJ Schmidt (https://github.com/ajschmidt8) - https://github.com/jakirkham URL: #15291
Following up on issue ( rapidsai/build-planning#15 ), drop RAPIDS version hard-coding in doc builds.