Added support for custom types in PTX parser #17861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
lamarrr
force-pushed
the
ptx-custom-types
branch
from
e5cc962 to
fee37d9
Compare
lamarrr
added
non-breaking
|
Probably should move this to 25.04 since 25.02 is in burndown. |
GregoryKimball
added
the
4 - Needs Review
davidwendt
requested changes
Feb 4, 2025
shrshi
reviewed
Feb 4, 2025
davidwendt
approved these changes
Feb 4, 2025
|
/ok to test |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PTX parser currently enforces a signature for each parameter.
It requires that the function have the following properties:
void *void const *pointers (if specified) orint32(if unspecified and unused)As you can imagine, this is very limiting for any use beyond what it was initially designed for.
This merge request removes the constraint totally and lets the user specify the types of the parameters.
This is needed for more flexible code-gen in UDFs, i.e. defining a function that transforms multiple columns into a single output column using an index as the first parameter is impossible with this limitation.
Note that the register types and sizes are checked against the parameter types during the compilation process.
There's also only a minimal level of safety that can be guaranteed given we are translating from PTX back to CUDA and much of the type information is lost in the process.
Checklist