Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dataframe protocol #17909

Open
wants to merge 7 commits into
base: branch-25.04
Choose a base branch
from

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Feb 4, 2025

Description

Follow-up to #17736

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function breaking Breaking change labels Feb 4, 2025
@vyasr vyasr self-assigned this Feb 4, 2025
@vyasr vyasr requested a review from a team as a code owner February 4, 2025 01:04
@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 4, 2025
@mroeschke
Copy link
Contributor

Hmm darn. Ideally we should have had warnings as errors enabled for cudf pandas tests based on the configs in pyproject.toml, but because we're using a pytest.ini for these tests it looks like we didn't anticipate the test failure here

@github-actions github-actions bot added the cudf.pandas Issues specific to cudf.pandas label Feb 4, 2025
@vyasr
Copy link
Contributor Author

vyasr commented Feb 4, 2025

Hmm yeah that is unfortunate. We should fix that in a follow-up PR. I don't know that we can reuse existing pyproject.toml files though given the special nature of these tests. Maybe our best bet is to just copy over filters from our other pyprojects?

@galipremsagar
Copy link
Contributor

/merge

@galipremsagar
Copy link
Contributor

galipremsagar commented Feb 4, 2025

I think we will need to investigate the massive increase in duration of pandas-tests job.

On a different pr it is(50 mins): https://github.com/rapidsai/cudf/actions/runs/13120888958/job/36623191308

On this pr it is consistently going beyond (1hr 30mins): https://github.com/rapidsai/cudf/actions/runs/13128280990/job/36670004745?pr=17909

@galipremsagar
Copy link
Contributor

I think we will need to investigate the massive increase in duration of pandas-tests job.

On a different pr it is(50 mins): https://github.com/rapidsai/cudf/actions/runs/13120888958/job/36623191308

On this pr it is consistently going beyond (1hr 30mins): https://github.com/rapidsai/cudf/actions/runs/13128280990/job/36670004745?pr=17909

I think we will need to investigate the massive increase in duration of pandas-tests job.

On a different pr it is(50 mins): https://github.com/rapidsai/cudf/actions/runs/13120888958/job/36623191308

On this pr it is consistently going beyond (1hr 30mins): https://github.com/rapidsai/cudf/actions/runs/13128280990/job/36670004745?pr=17909

I'm investigating what is causing this slowdown.

@mroeschke
Copy link
Contributor

Maybe not the root of the slowdown, but it appears tests/io/test_pickle.py::test_pickle_generalurl_read is taking a long amount of time on the 3 times pandas-tests was retried (the http calls are supposed to be mocked, but maybe not well enough)

2025-02-04T17:07:30.8282675Z [gw2] [ 99%] FAILED tests/io/test_pickle.py::test_pickle_generalurl_read[http://url.com] 
2025-02-04T17:36:11.9497790Z tests/io/test_pickle.py::test_pickle_generalurl_read[ftp://test.com] 

@vyasr vyasr added the DO NOT MERGE Hold off on merging; see PR for details label Feb 4, 2025
@vyasr
Copy link
Contributor Author

vyasr commented Feb 4, 2025

Marked as do not merge until Prem has a chance to get to the bottom of the perf hit.

@galipremsagar galipremsagar requested a review from a team as a code owner February 4, 2025 23:51
@galipremsagar galipremsagar requested a review from bdice February 4, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change cudf.pandas Issues specific to cudf.pandas DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants