Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize inout parameter #17911

Open
wants to merge 1 commit into
base: branch-25.04
Choose a base branch
from

Conversation

miscco
Copy link
Contributor

@miscco miscco commented Feb 4, 2025

This avoids failures in CCCL CI

Pulled out of #17793

@miscco miscco requested a review from a team as a code owner February 4, 2025 09:29
@miscco miscco requested review from mythrocks and ttnghia February 4, 2025 09:29
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Feb 4, 2025
@miscco miscco changed the base branch from branch-25.04 to branch-25.02 February 4, 2025 09:29
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to target 25.04 here, since 25.02 is in code freeze. Is this required for 25.02?

@miscco
Copy link
Contributor Author

miscco commented Feb 4, 2025

Not really required for 25.02 its more of a CI fix and CCCL will test 25.04 imminently

I can rebase on 25.04

@miscco miscco force-pushed the avoid_uninitialized_variable_warning branch from 4c9d7b5 to 60df568 Compare February 4, 2025 16:55
@miscco miscco requested review from a team as code owners February 4, 2025 16:55
@miscco miscco changed the base branch from branch-25.02 to branch-25.04 February 4, 2025 16:56
@vyasr vyasr removed request for a team, mythrocks, ttnghia, vyasr and galipremsagar February 4, 2025 23:21
@vyasr
Copy link
Contributor

vyasr commented Feb 4, 2025

/merge

@davidwendt davidwendt added the improvement Improvement / enhancement to an existing function label Feb 5, 2025
@davidwendt davidwendt added the non-breaking Non-breaking change label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants