Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] New MovieLens Example, Add Timing to Taobao Example #141

Open
wants to merge 7 commits into
base: branch-25.04
Choose a base branch
from

Conversation

alexbarghi-nv
Copy link
Member

@alexbarghi-nv alexbarghi-nv commented Feb 11, 2025

Adds a new example based on the MovieLens dataset in PyG. Also updates the Taobao example with better timing.

Corrects a small bug in the LinkLoader that prevented complete specification of heterogeneous graph input.

Copy link

copy-pr-bot bot commented Feb 11, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@alexbarghi-nv alexbarghi-nv self-assigned this Feb 11, 2025
@alexbarghi-nv alexbarghi-nv added feature request New feature or request non-breaking Introduces a non-breaking change labels Feb 11, 2025
@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review February 12, 2025 21:11
@alexbarghi-nv alexbarghi-nv requested a review from a team as a code owner February 12, 2025 21:11
Copy link
Member

@tingyu66 tingyu66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just left a nitpick.


if global_rank == 0:
print("Val")
val_start = perf_counter()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's safer to synchronize before perf_counter. train() should already sync implicitly due to the backward call, but I am not sure about test().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants