-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] New MovieLens Example, Add Timing to Taobao Example #141
base: branch-25.04
Are you sure you want to change the base?
[FEA] New MovieLens Example, Add Timing to Taobao Example #141
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just left a nitpick.
|
||
if global_rank == 0: | ||
print("Val") | ||
val_start = perf_counter() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's safer to synchronize before perf_counter. train()
should already sync implicitly due to the backward call, but I am not sure about test()
.
Adds a new example based on the MovieLens dataset in PyG. Also updates the Taobao example with better timing.
Corrects a small bug in the
LinkLoader
that prevented complete specification of heterogeneous graph input.