Create Conda CI test env in one step #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleFromNVIDIA
added
improvement
msarahan
reviewed
Feb 11, 2025
bdice
reviewed
Feb 11, 2025
There was a problem hiding this comment.
Are ARM tests doing anything here? Maybe they should exit earlier (or be skipped in the CI matrix) if not.
There are a few comments of the form # Reactivate the test environment back. I’m not sure if we have a test environment to go back to, with the new single-solve environments.
There was a problem hiding this comment.
We can do that in a follow-up PR. I'd like to limit the scope of this one to consolidating the environment creation.
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rapidsai/build-planning#22