Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coding of RAPIDS version where possible #45

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Remove hard-coding of RAPIDS version where possible #45

merged 4 commits into from
Mar 12, 2024
+59 −55

Conversation

KyleFromNVIDIA
Copy link
Contributor

  • Read VERSION file from CMake
  • Read cuvs.__version__ from docs build
  • Read VERSION file from shell scripts
  • Use variable substitution in Doxyfile
  • Update ci/release/update-version.sh

Issue: rapidsai/build-planning#15

@KyleFromNVIDIA KyleFromNVIDIA added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Mar 8, 2024
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners March 8, 2024 15:25
@benfred
Copy link
Member

benfred commented Mar 12, 2024

/merge

@rapids-bot rapids-bot bot merged commit 0e5aac6 into rapidsai:branch-24.04 Mar 12, 2024
55 checks passed
difyrrwrzd added a commit to difyrrwrzd/cuvs that referenced this pull request Aug 10, 2024
@difyrrwrzd
Remove hard-coding of RAPIDS version where possible (#45)
1d5cf1a 
* Read `VERSION` file from CMake
* Read `cuvs.__version__` from docs build
* Read `VERSION` file from shell scripts
* Use variable substitution in Doxyfile
* Update `ci/release/update-version.sh`

Issue: rapidsai/build-planning#15

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Bradley Dice (https://github.com/bdice)
  - Jake Awe (https://github.com/AyodeAwe)
  - Ben Frederickson (https://github.com/benfred)

URL: rapidsai/cuvs#45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfred benfred benfred approved these changes

@cjnolet cjnolet cjnolet approved these changes

@bdice bdice bdice approved these changes

@AyodeAwe AyodeAwe AyodeAwe approved these changes

Assignees
No one assigned
Labels
ci CMake cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KyleFromNVIDIA @benfred @cjnolet @bdice @AyodeAwe