This repository has been archived by the owner on Feb 3, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
add Python 3.12 support, prefer absolute paths in Dockerfiles #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
commented
Sep 10, 2024
@@ -31,7 +31,7 @@ RUN cat /dask.yml \ | |||
| sed -r "s/pyarrow=/pyarrow>=/g" \ | |||
| sed -r "s/pandas=/pandas>=/g" \ | |||
| sed -r "s/numpy=/numpy>=/g" \ | |||
> dask_unpinned.yml | |||
> /dask_unpinned.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right below, this is referenced as /dask_unpinned.yml
(absolute path).
That means this has only been working because the working directory happens to be /
. Making this an absolute path just makes this a little safer, in case that working directory is changed in the base image in the future.
pentschev
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jameslamb .
charlesbluca
approved these changes
Sep 11, 2024
Thanks @jameslamb! Just kicked off a rebuild of the image matrix (you should be able to see the status of all runs here) |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#40
RAPIDS is adding support for Python 3.12 in its 24.10 release. All of the libraries used by images built from this repo (
cudf
,dask-cudf
,ucx-py
) have been updated... so this proposes adding Python 3.12 images here.Notes for Reviewers
How I tested this
On an x86_64 machine with CUDA driver 535: