Skip to content

Conversation

@miscco
Copy link
Collaborator

@miscco miscco commented Nov 13, 2025

Fixes #614

@miscco miscco requested a review from a team as a code owner November 13, 2025 16:56
@miscco miscco requested review from msarahan and removed request for a team November 13, 2025 16:56
Copy link
Collaborator

@trxcllnt trxcllnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we tried my suggestion?


- { features: [*python, *dood, *llvm_14, { <<: *cuda_prev_min, <<: *cccl_cuda_opts }, *clang_format_cccl, *clangd_dev, *cccl_dev], env: *llvm_env }
- { features: [*python, *dood, *llvm_14, { <<: *cuda_prev_max, <<: *cccl_cuda_opts }, *clang_format_cccl, *clangd_dev, *cccl_dev], env: *llvm_env }
- { features: [*python, *dood, *llvm_14, { <<: *cuda_prev_min, <<: *cccl_cuda_opts }, *clang_format_cccl, *clangd_dev, *cccl_dev, *libcxx_14 ], env: *llvm_env }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we install clang-format first?

Suggested change
- { features: [*python, *dood, *llvm_14, { <<: *cuda_prev_min, <<: *cccl_cuda_opts }, *clang_format_cccl, *clangd_dev, *cccl_dev, *libcxx_14 ], env: *llvm_env }
- { features: [*python, *dood, *clang_format_cccl, *llvm_14, { <<: *cuda_prev_min, <<: *cccl_cuda_opts }, *clangd_dev, *cccl_dev ], env: *llvm_env }

Comment on lines +48 to +55
x-libcxx-14: &libcxx_14 { name: "llvm", version: "14", packages: "libcxx-dev libcxxabi-dev libunwind-dev" }
x-libcxx-15: &libcxx_15 { name: "llvm", version: "15", packages: "libcxx-dev libcxxabi-dev libunwind-dev" }
x-libcxx-16: &libcxx_16 { name: "llvm", version: "16", packages: "libcxx-dev libcxxabi-dev libunwind-dev" }
x-libcxx-17: &libcxx_17 { name: "llvm", version: "17", packages: "libcxx-dev libcxxabi-dev libunwind-dev" }
x-libcxx-18: &libcxx_18 { name: "llvm", version: "18", packages: "libcxx-dev libcxxabi-dev libunwind-dev" }
x-libcxx-19: &libcxx_19 { name: "llvm", version: "19", packages: "libcxx-dev libcxxabi-dev libunwind-dev" }
x-libcxx-20: &libcxx_20 { name: "llvm", version: "20", packages: "libcxx-dev libcxxabi-dev libunwind-dev" }
x-libcxx-21: &libcxx_21 { name: "llvm", version: "21", packages: "libcxx-dev libcxxabi-dev libunwind-dev" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
x-libcxx-14: &libcxx_14 { name: "llvm", version: "14", packages: "libcxx-dev libcxxabi-dev libunwind-dev" }
x-libcxx-15: &libcxx_15 { name: "llvm", version: "15", packages: "libcxx-dev libcxxabi-dev libunwind-dev" }
x-libcxx-16: &libcxx_16 { name: "llvm", version: "16", packages: "libcxx-dev libcxxabi-dev libunwind-dev" }
x-libcxx-17: &libcxx_17 { name: "llvm", version: "17", packages: "libcxx-dev libcxxabi-dev libunwind-dev" }
x-libcxx-18: &libcxx_18 { name: "llvm", version: "18", packages: "libcxx-dev libcxxabi-dev libunwind-dev" }
x-libcxx-19: &libcxx_19 { name: "llvm", version: "19", packages: "libcxx-dev libcxxabi-dev libunwind-dev" }
x-libcxx-20: &libcxx_20 { name: "llvm", version: "20", packages: "libcxx-dev libcxxabi-dev libunwind-dev" }
x-libcxx-21: &libcxx_21 { name: "llvm", version: "21", packages: "libcxx-dev libcxxabi-dev libunwind-dev" }
x-libcxx-14: &libcxx_14 { name: "llvm", version: "14", packages: "libc++-dev libc++abi-dev libunwind-dev" }
x-libcxx-15: &libcxx_15 { name: "llvm", version: "15", packages: "libc++-dev libc++abi-dev libunwind-dev" }
x-libcxx-16: &libcxx_16 { name: "llvm", version: "16", packages: "libc++-dev libc++abi-dev libunwind-dev" }
x-libcxx-17: &libcxx_17 { name: "llvm", version: "17", packages: "libc++-dev libc++abi-dev libunwind-dev" }
x-libcxx-18: &libcxx_18 { name: "llvm", version: "18", packages: "libc++-dev libc++abi-dev libunwind-dev" }
x-libcxx-19: &libcxx_19 { name: "llvm", version: "19", packages: "libc++-dev libc++abi-dev libunwind-dev" }
x-libcxx-20: &libcxx_20 { name: "llvm", version: "20", packages: "libc++-dev libc++abi-dev libunwind-dev" }
x-libcxx-21: &libcxx_21 { name: "llvm", version: "21", packages: "libc++-dev libc++abi-dev libunwind-dev" }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: clang-format installations uninstalls libc++ packages

2 participants