Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs on using CI artifacts across PRs #577

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jameslamb
Copy link
Member

During the 25.02 release, I worked through a bunch of PRs that relied on other PRs' wheels and conda packages, sometimes in a dependency chain 3 or 4 libraries deep.

This proposes some changes to the docs on how to do that. In general... instead of manually modifying every ci/ script, it's possible to put the changes into a single ci/use_{conda_packages,wheels}_from_prs.sh that is then source'd into all scripts, reducing duplication and mistakes.

@jameslamb jameslamb requested a review from a team as a code owner February 14, 2025 23:52
Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 14, 2025 11:53pm

Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for docs-rapids-ai ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3e682da
🔍 Latest deploy log https://app.netlify.com/sites/docs-rapids-ai/deploys/67afd750d9f1790008f46177
😎 Deploy Preview https://deploy-preview-577--docs-rapids-ai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jameslamb
Copy link
Member Author

I don't have permissions to add reviewers in this repo, so tagging a few folks I expect would be interested:

@vyasr @bdice @gforsyth @KyleFromNVIDIA @msarahan @divyegala

Copy link

@msarahan msarahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big improvement! Thanks for your work on this.

Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very needed improvement. I was not aware of how easy it can be to use artifacts from other PRs, and it seems to me the right way to do it than updating get_raft.cmake in cuml, for example.

@vyasr
Copy link

vyasr commented Feb 18, 2025

Thanks James! I forgot to follow up on this request with you, so thanks for remembering and following up. I have no review/merge powers here so I'll let @bdice take a look since he does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants