-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docs on using CI artifacts across PRs #577
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for docs-rapids-ai ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
I don't have permissions to add reviewers in this repo, so tagging a few folks I expect would be interested: @vyasr @bdice @gforsyth @KyleFromNVIDIA @msarahan @divyegala |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big improvement! Thanks for your work on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very needed improvement. I was not aware of how easy it can be to use artifacts from other PRs, and it seems to me the right way to do it than updating get_raft.cmake
in cuml, for example.
Thanks James! I forgot to follow up on this request with you, so thanks for remembering and following up. I have no review/merge powers here so I'll let @bdice take a look since he does. |
During the 25.02 release, I worked through a bunch of PRs that relied on other PRs' wheels and conda packages, sometimes in a dependency chain 3 or 4 libraries deep.
This proposes some changes to the docs on how to do that. In general... instead of manually modifying every
ci/
script, it's possible to put the changes into a singleci/use_{conda_packages,wheels}_from_prs.sh
that is thensource
'd into all scripts, reducing duplication and mistakes.