Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Up New Repo, Adding Files, etc. #5

Merged
merged 41 commits into from
Oct 29, 2024
Merged

Setting Up New Repo, Adding Files, etc. #5

merged 41 commits into from
Oct 29, 2024

Conversation

nv-rliu
Copy link
Contributor

@nv-rliu nv-rliu commented Oct 11, 2024

Closes https://github.com/rapidsai/graph_dl/issues/620
Closes https://github.com/rapidsai/graph_dl/issues/621

This PR updates a handful of files for the new nx-cugraph repository.

Proposed Changes

  • Setup the CODEOWNERS file with proper roles each of the sub-directories.
  • Adding 5 "Issue Template" files, borrowing a lot of formatting/conventions from those inside the cugraph repo.
  • Create new-issues-to-triage-projects.yaml
  • Update pre-commit.yaml
  • Add a ci/check_style.sh script to be used in CI
  • Minor comments, adding lines to end of files, update copyright statement.
  • Move the contents of the python/nx_cugraph/ directory up one level.

Note for Reviewers

  • Need to ensure that the roles in CODEOWNERS are delegated properly. There is still a Warning that the file contains errors, and perhaps it's because the mentioned roles are "unknown", aka, need to be created for the rapidsai organization?
  • I tested build.sh and its various CLI args to make sure it is working properly, but there might be additional code in there that can be safely removed.
    • Are lines 119-128 in build.sh are necessary for a pure-Python project like nx-cugraph? Can they be safely removed?
  • You may notice a lot of "File was renamed..." changes. Those were mainly migrating files from python/nx-cugraph/ up two levels so nx_cugraph and _nx_cugraph all inside the root directory.

@github-actions github-actions bot added the ci label Oct 11, 2024
@nv-rliu nv-rliu marked this pull request as ready for review October 11, 2024 15:59
@nv-rliu nv-rliu added breaking Introduces a breaking change improvement Improves an existing functionality labels Oct 11, 2024
@nv-rliu nv-rliu marked this pull request as draft October 11, 2024 16:30
@nv-rliu nv-rliu marked this pull request as ready for review October 15, 2024 19:26
@github-actions github-actions bot removed the python label Oct 15, 2024
@nv-rliu nv-rliu requested review from rlratzel and eriknw October 15, 2024 19:32
@rlratzel
Copy link
Contributor

Do you think we need a python subdir at all? Maybe we can just have nx_cugraph at the root level, similar to what NetworkX and other pure-python projects do?

Copy link
Contributor

@eriknw eriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yaml Outdated Show resolved Hide resolved
.github/copy-pr-bot.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
build.sh Outdated Show resolved Hide resolved
ci/check_style.sh Outdated Show resolved Hide resolved
lint.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@nv-rliu nv-rliu requested a review from bdice October 28, 2024 17:05
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small suggestions, otherwise the changes since my last review look good.

.github/CODEOWNERS Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@nv-rliu nv-rliu merged commit 555f7fd into rapidsai:branch-24.12 Oct 29, 2024
3 checks passed
@nv-rliu nv-rliu deleted the branch-24.12-setup-repo branch October 29, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Introduces a breaking change ci improvement Improves an existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants