-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting Up New Repo, Adding Files, etc. #5
Setting Up New Repo, Adding Files, etc. #5
Conversation
…nx-cugraph into branch-24.12-setup-repo
Do you think we need a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
…nx-cugraph into branch-24.12-setup-repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small suggestions, otherwise the changes since my last review look good.
Co-authored-by: Bradley Dice <[email protected]>
…into rapidsai-branch-24.12
…-24.12' into branch-24.12-setup-repo
Closes https://github.com/rapidsai/graph_dl/issues/620
Closes https://github.com/rapidsai/graph_dl/issues/621
This PR updates a handful of files for the new nx-cugraph repository.
Proposed Changes
CODEOWNERS
file with proper roles each of the sub-directories.new-issues-to-triage-projects.yaml
pre-commit.yaml
ci/check_style.sh
script to be used in CIpython/nx_cugraph/
directory up one level.Note for Reviewers
Need to ensure that the roles inCODEOWNERS
are delegated properly. There is still a Warning that the file contains errors, and perhaps it's because the mentioned roles are "unknown", aka, need to be created for the rapidsai organization?build.sh
and its various CLI args to make sure it is working properly, but there might be additional code in there that can be safely removed.build.sh
are necessary for a pure-Python project likenx-cugraph
? Can they be safely removed?python/nx-cugraph/
up two levels sonx_cugraph
and_nx_cugraph
all inside the root directory.