Adds notebook for Jaccard Similarity #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlratzel
added
doc
eriknw
reviewed
Jan 30, 2025
eriknw
reviewed
Jan 30, 2025
eriknw
reviewed
Jan 30, 2025
eriknw
reviewed
Jan 30, 2025
There was a problem hiding this comment.
Looks good! Only a couple minor grammar/spelling nits.
Since timing is such a key point of the notebook, I think it would be nice to either include the outputs in the notebook or include some timing information in the discussion. I suspect most readers will be "fly by" skimmers and won't run the notebook themselves.
Also, can we provide a link to open this notebook in colab?
eriknw
reviewed
Jan 30, 2025
nv-rliu
reviewed
Jan 30, 2025
…2-jaccard_notebook
…ional markdown cells for clarity.
eriknw
requested changes
Jan 31, 2025
eriknw
reviewed
Feb 4, 2025
eriknw
approved these changes
Feb 4, 2025
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a notebook to demonstrate nx-cugraph's support for
nx.jaccard_coefficients()by implementing a simple movie recommendation system based on MovieLens data.This notebook will also be made available in Google Colab and referenced in an upcoming blog.