Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch 25.04 merge 25.02 #73

Closed

Conversation

rlratzel
Copy link
Contributor

Resolves forward merge conflicts in PR #68

bdice and others added 4 commits January 28, 2025 22:32
This PR uses CUDA 12.8.0 to build and test.

xref: rapidsai/build-planning#139

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: rapidsai#66
Here are results from a single round of benchmarks for louvain and leiden:
```
Name (time in ms)                                                                 Min
bench_leiden_communities[ds=karate-backend=cugraph-preconverted]              32.3493
bench_louvain_communities[ds=karate-backend=cugraph-preconverted]             15.2782
bench_leiden_communities[ds=netscience-backend=cugraph-preconverted]          83.5688
bench_louvain_communities[ds=netscience-backend=cugraph-preconverted]         34.1273
bench_leiden_communities[ds=email_Eu_core-backend=cugraph-preconverted]       81.3393
bench_louvain_communities[ds=email_Eu_core-backend=cugraph-preconverted]      50.0181
bench_leiden_communities[ds=amazon0302-backend=cugraph-preconverted]         755.0755
bench_louvain_communities[ds=amazon0302-backend=cugraph-preconverted]        939.3094

Name (time in s)                                                                  Min
bench_leiden_communities[ds=cit-patents-backend=cugraph-preconverted]          8.2224
bench_louvain_communities[ds=cit-patents-backend=cugraph-preconverted]         7.7888
bench_leiden_communities[ds=soc-livejournal1-backend=cugraph-preconverted]    16.1031
bench_louvain_communities[ds=soc-livejournal1-backend=cugraph-preconverted]   22.2967
bench_leiden_communities[ds=hollywood-backend=cugraph-preconverted]           22.7196
bench_louvain_communities[ds=hollywood-backend=cugraph-preconverted]          24.3643
bench_leiden_communities[ds=europe_osm-backend=cugraph-preconverted]          39.7309
bench_louvain_communities[ds=europe_osm-backend=cugraph-preconverted]         46.4452
```

Authors:
  - Erik Welch (https://github.com/eriknw)

Approvers:
  - Rick Ratzel (https://github.com/rlratzel)

URL: rapidsai#67
Adds support for `jaccard_coefficient` to nx-cugraph.

This includes a test, but relies largely on the existing test coverage provided by NetworkX. The test included here could (should) be submitted to NetworkX though in a separate PR, since it is not covering anything unique to nx-cugraph.

A benchmark is also included, with results showing 2-4X speedup. I've seen much, much larger speedup on a different graph (large movie review bipartite graph, showing 966s for NX, 2s for nx-cugraph = ~500X), so I need to investigate further.  This investigation need not prevent this PR from being merged now though.

![image](https://github.com/user-attachments/assets/3ceb7d62-50c4-437e-96d2-0ab452dd39d2)

Authors:
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Ralph Liu (https://github.com/nv-rliu)
  - Erik Welch (https://github.com/eriknw)

URL: rapidsai#62
@rlratzel rlratzel added the DO NOT MERGE Hold off on merging; see PR for details label Jan 30, 2025
@rlratzel rlratzel self-assigned this Jan 30, 2025
@rlratzel rlratzel requested review from a team as code owners January 30, 2025 22:27
@rlratzel rlratzel requested a review from bdice January 30, 2025 22:27
@rlratzel rlratzel changed the base branch from branch-25.02 to branch-25.04 January 30, 2025 22:27
@rlratzel rlratzel requested a review from a team as a code owner January 30, 2025 22:27
@github-actions github-actions bot added conda Relates to conda packaging benchmarks labels Jan 30, 2025
@rlratzel
Copy link
Contributor Author

rlratzel commented Feb 3, 2025

Changes should be covered by this PR: #76

@rlratzel rlratzel closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks conda Relates to conda packaging DO NOT MERGE Hold off on merging; see PR for details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants