Use dependencies.yaml #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jameslamb
reviewed
Jun 4, 2024
ci/test_conda.sh
Outdated
|
|
||
| rapids-dependency-file-generator \ | ||
| --output conda \ | ||
| --file_key test \ |
There was a problem hiding this comment.
Suggested change
| --file_key test \ | |
| --file-key test \ |
Could you change these to --file-key (hyphen instead of underscore)?
Per rapidsai/dependency-file-generator#89.
That'd avoid this warning: https://github.com/rapidsai/pynvjitlink/actions/runs/9358256535/job/25759883265?pr=86#step:7:25
/opt/conda/lib/python3.9/site-packages/rapids_dependency_file_generator/_cli.py:94: UserWarning: The use of --file_key is deprecated. Use -f or --file-key instead.
warnings.warn("The use of --file_key is deprecated. Use -f or --file-key instead.")
There was a problem hiding this comment.
Done in ed7b254! Ready for another review.
jameslamb
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves some TODO items by adopting
dependencies.yamlandrapids-dependency-file-generator.