Conda package has requirements/host dependency on conda-verify

[jakirkham]

Noticed that the Conda recipe depends on conda-verify in requirements/host

rapids-metadata/conda/recipes/rapids-metadata/meta.yaml

Line 36 in 20e30ee

- conda-verify

Though not seeing other uses of it in the library

Is conda-verify needed by rapids-metadata? If so, how is it used?

[jameslamb]

I strongly suspect (though don't have evidence), that it was added to silence this warning from conda-build:

Importing conda-verify failed. Please be sure to test your packages. conda install conda-verify to make this message go away.

https://github.com/conda/conda-build/blob/e5b060efd18665b2810ecabac48a89e322943266/conda_build/build.py#L1931-L1934

[jakirkham]

Thanks James! 🙏

That makes sense

In that case, we should drop this from the requirements and add it to the CI images

Started this in PR: rapidsai/ci-imgs#237

[jakirkham]

Should add we already get this warning on CI:

WARNING: Importing conda-verify failed.  Please be sure to test your packages.  conda install conda-verify to make this message go away.

So having this in requirements/host isn't fixing that

[jameslamb]

welp 🙃

Then either there's some other reason we added that that I don't remember (looks like there wasn't any commentary on it in #8), or it's just not working as intended anyway and we can safely remove it.

[jakirkham]

It seems this pattern shows up in other places. It would be good to get more clarity on its usage elsewhere

[KyleFromNVIDIA]

I honestly don't remember even adding the conda-verify dependency. It's likely that I cargo-culted it from elsewhere :)

[KyleFromNVIDIA]

Looks like it was added in a076a31, which indicates that it was modeled after https://github.com/rapidsai/rapids-build-backend.

[vyasr]

I added it to rapids-build-backend in hopes of silencing the warning, and when it didn't work I guess I just forgot to remove it. I'd have liked to have figured out how to fix the warning, but at this stage it's probably a moot point since we're rewriting all our recipes to use rattler anyway. I say drop the dependency and move on, it'll be obsoleted by the migration even if we could fix it.

[jakirkham]

Thanks all! 🙏

Agree we can remove it then

Have raised this in issue: rapidsai/build-planning#150