-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conda-verify
to CI images
#237
Conversation
Think we should wait until 25.02 is out Canceling CI for now and marking do not merge We can revisit after the release |
Agree with you on not doing this in 25.02. I have a question in the interim... is installing |
Yes
|
Is this worth doing in light of rapidsai/build-planning#47? If we migrate everything to rattler-build it's not going to use conda-verify anyway, at which point we might as well remove it to debloat the image no? |
Which issue/PR is that referencing? When I click the links it takes me to a 2yr old PR on this repo entitled "WIP: native docker builds". Am guessing that something else was meant or I'm missing context In any event this came up because I think having the explicit install of As to |
Whoops sorry forgot that we were in a different repo, I meant rapidsai/build-planning#47. IOW this feels superfluous given the impending switch to rattler-build. |
I'll wait to make that determination until we have more light on this question: rapidsai/rapids-metadata#43 |
Following more discussion in the aforementioned issue, we have concluded we can drop This is tracked in issue: rapidsai/build-planning#150 Going to close as won't fix |
This adds
conda-verify
to our CI images to resolve a warning about it being missing.