Conversation
p-maxwell
left a comment
There was a problem hiding this comment.
Occasionally you're untidy with your formatting, but you're precise with your logic. It looks like you're understanding this well. Keep it up.
| ]; | ||
|
|
||
| console.log(writers); | ||
| console.log(writers.alive); |
There was a problem hiding this comment.
This logs undefined, did you mean to do this?
There was a problem hiding this comment.
oh yea, i will adjust that
| " " + | ||
| element.lastName + | ||
| " " + | ||
| element.lastName + |
| var bottle = { | ||
| volume: 0, | ||
| fill: function() { | ||
| return (this.volume = 100); |
There was a problem hiding this comment.
okay do you mean just this.volume=100; should be fine?
| // calling this function should make you bottles volume = 100; | ||
| }, | ||
| drink: function() { | ||
| return (this.volume -= 10); |
| // calling this function should decrease your bottles volume by 10; | ||
| }, | ||
| empty: function() { | ||
| if (bottle.volume === 0) { |
There was a problem hiding this comment.
i think just need just this.volume=...
There was a problem hiding this comment.
Yes, return this.volume === 0; is a good short way to write it.
| } else { | ||
| return house1.address; | ||
| } | ||
| } |
| } else { | ||
| return "sorry you dont have enough money"; | ||
| } | ||
| } |
| reachableByFerry.transportations.includes("ferry") | ||
| ) | ||
| .map(reachableByFerry => reachableByFerry.destinationName); | ||
| //var destinationNameReachableByFerry = travelDestinations |
There was a problem hiding this comment.
Best not to leave commented out code around, but the code that isn't commented out is all good.
There was a problem hiding this comment.
ok thanks i will take care of that.
No description provided.