Fix association rules 1112 #1141
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @rasbt,
This PR addresses Issue #1112, where the association_rules function became broken for many users in v0.23.2 because num_itemsets was changed to a mandatory positional argument. This regression broke existing scripts that relied on the previous API.
Changes Implemented
Changed num_itemsets from a mandatory argument to an optional one by setting its default value to None.
Implemented logic to automatically infer num_itemsets from df_orig if provided.
Set the default to 1 when neither num_itemsets nor df_orig is provided, maintaining backward compatibility with the historical behavior of the library.
Updated error messages to provide better guidance when null_values=True.
Verification
Manual Test: Verified that the reproduction code provided in #1112 now runs successfully without a TypeError.
Automated Tests: Ran pytest mlxtend/frequent_patterns/tests/test_association_rules.py and all tests passed.
Code Quality: Formatted the code using ruff to ensure compliance with the project's styling guidelines.