Test Home component with SSE mocking #824
Conversation
| ); | ||
|
|
||
| await waitFor(() => { | ||
| const totalBalanceValue = screen |
There was a problem hiding this comment.
Could we just do the same, we do in the unit-tests, i.e.
expect(await screen.findByText("123,456 SAT")).toBeInTheDocument();
Adding dataTestIds is not good practice I believe. That's why we avoided these in the unit-tests as well.
There was a problem hiding this comment.
Adding dataTestIds is not good practice I believe. That's why we avoided these in the unit-tests as well.
Yes, was just frustrated because I didn't get the result I wanted at first 😅
Could we just do the same, we do in the unit-tests, i.e.
expect(await screen.findByText("123,456 SAT")).toBeInTheDocument();
Agreed!
Since the messaging mock now works, I would do tests for the component (e.g. the balance test for the WalletCard) & in the Home I could check for the higher-level stuff, e.g. when does the loading spinner appear etc.
|
Looks nice! 👏 |
This is just a basic test at first, but it shows that it can work.
Had to fix some stuff since africa, but now it works correctly.
Will have to refine it and will take some more time, but with that my main issue with using websockets instead of sse will be fixed and #773 could be closed.
@escapedcat What do you think?