RDBC-909 - Returning class instances in client causes issues in Next.js — responses should be plain objects #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `returnPlainJsObjects` convention to optionally convert API results to plain objects. Update query methods to honor this setting by utilizing `JsonSerializer.toPlainObject`. Include support for environments requiring serializable results, such as Next.js.
kalczur
reviewed
Jul 2, 2025
| const array = [...results]; | ||
|
|
||
| if (this.conventions.returnPlainJsObjects) { | ||
| return array.map(item => JsonSerializer.toPlainObject(item)) |
There was a problem hiding this comment.
Can item be undefined? if yes we will get SyntaxError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
returnPlainJsObjectsconvention to optionally convert API results to plain objects. Update query methods to honor this setting by utilizingJsonSerializer.toPlainObject. Include support for environments requiring serializable results, such as Next.js.