Perf: Implement tool caching to reduce filesystem I/O#19
Open
onne wants to merge 1 commit into
Open
Conversation
- Discover and load all tools from the tools directory caching the promise. - Freeze cached results to prevent mutations. - Export resetToolCache for cleaner test isolation. - Update tests to ensure cache consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a caching layer for tool discovery in the autoloader, significantly reducing filesystem I/O and dynamic import overhead on every request.
Why this approach?
Promise. This prevents a race condition where multiple concurrent first-requests would all trigger the filesystem scan and module loading simultaneously.Object.freeze()'d. Since the same array reference is returned to all callers, this prevents a consumer from accidentally mutating the cached tools (e.g., pushing or sorting), which would poison the cache for future requests.resetToolCache()utility to ensure tests can cleanly reset the module state without resorting to brittlevi.resetModules()gymnastics.Resolves #17