Enable PHP 8.4 compat #220
Conversation
Include PHP 8.3 in old_stable and set current_stable to 8.4. This ensures that the CI pipeline tests against a wider range of PHP versions, providing better coverage and compatibility checks.
Upgraded the PHP version from 8.2 to 8.3 in static-analysis and coding-standards workflow files. This ensures compatibility with the latest PHP features and security updates.
WalkthroughThe pull request includes updates to several GitHub Actions workflow configurations. The Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CI Workflow
participant GitHub Actions
participant PHP Environment
User->>CI Workflow: Trigger CI
CI Workflow->>GitHub Actions: Start workflow
GitHub Actions->>PHP Environment: Set up PHP 8.3
PHP Environment-->>GitHub Actions: PHP ready
GitHub Actions->>CI Workflow: Run tests
CI Workflow-->>User: CI results
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This commit updates the GitHub Actions checkout action from version 2 to version 3. This change ensures compatibility with the latest features and security improvements provided in v3. Make sure to review any breaking changes in the new version's documentation.
Updated the GitHub Actions workflow to use version 4 of the upload-artifact action. This ensures compatibility with the latest features and improvements provided by the action.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (1)
.github/workflows/continuous-integration-pecl.yml (1)
Line range hint
13-13: Add PHP 8.4 to the test matrix for compatibility testing.The PR objective is to enable PHP 8.4 compatibility, but the workflow doesn't test against PHP 8.4. This could lead to undiscovered compatibility issues.
Apply this diff to include PHP 8.4 testing:
strategy: matrix: - php-version: ['8.1', '8.2', '8.3'] + php-version: ['8.1', '8.2', '8.3', '8.4']Note: Since PHP 8.4 is still in development, consider adding:
experimental: [true] include: - php-version: '8.4' experimental: trueThis marks PHP 8.4 as experimental and prevents CI failures from blocking merges.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (4)
.github/workflows/coding-standards.yml(1 hunks).github/workflows/continuous-integration-pecl.yml(2 hunks).github/workflows/continuous-integration.yml(1 hunks).github/workflows/static-analysis.yml(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- .github/workflows/coding-standards.yml
🔇 Additional comments (2)
.github/workflows/continuous-integration-pecl.yml (2)
18-18: LGTM: Good practice to update checkout action.
Updating to actions/checkout@v3 is a good practice as it includes security updates and performance improvements.
105-105: LGTM: Good practice to update upload-artifact action.
Updating to actions/upload-artifact@v4 is beneficial as it includes improved performance and reliability features.
Summary by CodeRabbit
New Features
Chores