Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Kuberay autoscaler should use numOfHosts to calculate max workers #2820

Open
2 tasks done
richardsliu opened this issue Jan 25, 2025 · 1 comment
Open
2 tasks done
Labels
bug Something isn't working triage

Comments

@richardsliu
Copy link
Contributor

Search before asking

  • I searched the issues and found no similar issues.

KubeRay Component

ray-operator

What happened + What you expected to happen

Kuberay autoscaler currently uses the maxReplicas field in the worker group spec to determine maxWorkers: https://github.com/ray-project/ray/blob/master/python/ray/autoscaler/_private/kuberay/autoscaling_config.py#L197

This is used by the Ray autoscaler to determine if workers need to be terminated: https://github.com/ray-project/ray/blob/master/python/ray/autoscaler/_private/autoscaler.py#L1004

The maximum number of pods should be maxReplicas * numOfHosts, otherwise when numOfHosts > 1 this could result in workers getting terminated unintentionally.

Reproduction script

n/a

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@ryanaoleary
Copy link
Contributor

Related PR that would close this issue: ray-project/ray#48212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

2 participants