Update KubeRay Autoscaler to use NumOfHosts for min/max workers #48212
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan O'Leary <[email protected]>
|
@hongchaodeng is a code owner able to review/merge this for me? |
jcotant1
added
the
kuberay
Signed-off-by: ryanaoleary <[email protected]>
|
Related Issue: |
|
Closes #2820 |
Open
2 tasks
ryanaoleary
requested review from
a team,
sven1977 and
simonsays1980
as code owners
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
ryanaoleary
force-pushed
the
tpu-max-workers
branch
from
700abff to
0182cf4
Compare
Oh sorry about that, I fixed the improper rebase, not sure why those other commits got added to the PR. |
Signed-off-by: Ryan O'Leary <[email protected]>
kevin85421
approved these changes
Feb 5, 2025
| @@ -109,7 +109,7 @@ def _get_basic_autoscaling_config() -> dict: | |||
| # Same as "small-group" with a TPU resource entry added | |||
| # and modified max_workers and node_config. | |||
| "tpu-group": { | |||
| "max_workers": 4, | |||
| "max_workers": 8, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR updates
min_workersandmax_workersin the autoscaleravailable_node_typesto account for the value ofnumOfHosts, defaulting to 1 when this value is not set. This doesn't block multi-host autoscaling currently, since you can just set the value ofminReplicasandmaxReplicasto the desired number of multi-host workers, but this change would be helpful to avoid unexpected behavior for users.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.