Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][kubectl-plugin] make tests use a temporary kube config #2894

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

davidxia
Copy link
Contributor

@davidxia davidxia commented Feb 4, 2025

file that's not at the default path. Right now tests fail if there's a K8s
current context set with a command like kubectl config use-context my-context.

This change allows tests to pass regardless of current context.

Signed-off-by: David Xia [email protected]

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@davidxia
Copy link
Contributor Author

davidxia commented Feb 4, 2025

this is a follow-up to #2892

docs/development/development.md Outdated Show resolved Hide resolved
kubectl-plugin/DEVELOPMENT.md Outdated Show resolved Hide resolved
kubectl-plugin/pkg/util/test_utils.go Outdated Show resolved Hide resolved
@MortalHappiness
Copy link
Member

@truongminhdien Please don't spam comments.

Copy link
Member

@MortalHappiness MortalHappiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

file that's not at the default path. Right now tests fail if there's a K8s
current context set with a command like `kubectl config use-context
my-context`.

This change allows tests to pass regardless of current context.

Signed-off-by: David Xia <[email protected]>
@davidxia
Copy link
Contributor Author

davidxia commented Feb 5, 2025

rebased to fix conflicts

@kevin85421 kevin85421 merged commit 029cd78 into ray-project:master Feb 5, 2025
20 checks passed
@davidxia davidxia deleted the patch44 branch February 5, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants