Add example ArgoCD Deployment #4148
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was investigating odd behaviour where requesting exact number of workers via the python sdk was not behaving as expected. At first I thought it was related to this: #3794. However, even after the fix, I was not observing any different behaviour.
Then I thought to try and have ArgoCD ignore the
replicasfield, and then, everything started working as expected.I thought it be best to convey this in an example, and I could not find any documentation on how to deploy using ArgoCD (which also has a couple of lines that one needs to be aware about). IIRC I pieced it together based on some github issues and debugging.
The important point is that when managing Ray via ArgoCD with the Autoscaler enabled, the
ignoreDifferencesmust be managed properly to get the expected behaviour of the Autoscaler.I would have attached screenshots, but from a PR review perspective, this doesn't prove anything. Essentially what I did was:
ignoreDifferencessection, request X number of workers viaray.autoscaler.sdk.request_resources, kept changing it. When increasing X, it worked as expected and quite speedily. When reducing X, it takes ~10 mins (based on my setting) then workers start spinning down. Eventually requesting 1 worker.ignoreDifferencessection, request X number of workers. Then, requesting more than X, nothing happens. Request X=1, nothing happens. Delete theRayCluster, start back at original state, request Y, sometimes get Y, sometimes do not get Y workers.