[refactor] Move custom_types from util/state to _private/
#50183
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
commented
Feb 3, 2025
| @@ -72,9 +71,19 @@ | |||
| "DRIVER_TASK", | |||
| ] | |||
| TypeTaskType = Literal[tuple(TASK_TYPE)] | |||
| TypeReferenceType = Literal[ | |||
| tuple(reference_type.value for reference_type in ReferenceType) | |||
| # TODO(kevin85421): `class ReferenceType(Enum)` is defined in | |||
There was a problem hiding this comment.
To make this PR easier to review, I will open a follow up PR to address this instead of including in this PR.
ray/python/ray/dashboard/memory_utils.py
Line 47 in 766a525
Signed-off-by: kaihsun <[email protected]>
kevin85421
force-pushed
the
20250202-devbox1-tmux-19-ray2
branch
from
8b366a5 to
8a513f2
Compare
Signed-off-by: kaihsun <[email protected]>
dentiny
reviewed
Feb 5, 2025
| # `dashboard/memory_utils.py` to avoid complex dependencies. I redefined | ||
| # it here. Eventually, we should remove the one in `dashboard/memory_utils.py` | ||
| # and define it under `ray/_private`. | ||
| REFERENCE_TYPE = [ |
There was a problem hiding this comment.
Now we have two REFERENCE_TYPEs in our codebase, one for enum list, another for string list;
wondering if it's possible to combine them into one?
dentiny
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
custom_types.pydefines valid options for the Ray system, such as task status and actor status. However, some parts of the Ray codebase redefine this set of valid options or hardcode it as strings in multiple places. It will be useful to movecustom_typesto the top-level of the repo so that many other places can import it.Follow up:
custom_typesto refactor some functions.class TypeReferenceTypein a place other than dashboard.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.