Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add CancelTaskWithResourceShapes to Node Raylet Client and Node Manager #50200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MengjinYan
Copy link
Collaborator

Why are these changes needed?

This is the part#2 of the PRs to resolve #45909.

This PR:

  • Added a CancelTaskWithResourceShapes to the NodeManagerService.
  • The corresponding calls are added to the RayletClient as well
  • The CancelTaskWithResourceShape will leverage the functions in ClusterTaskManager to cancel the tasks that matches certain resource shapes on the node.
  • The corresponding tests are added as well.

There will be one more followup PR to leverage the API to cancel the tasks with requirements matches the infeasible tasks resource requirements obtained from the autoscaler.

Also, note that the implementation assumes:

  1. The same resource shape should be either feasible or infeasible on a certain node
  2. The PlacementConstraint doesn't impact whether a task is infeasible or not

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make infeasible tasks error much more obvious
1 participant