Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] cache test results for cpp/cicd tests #50201

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

aslonnie
Copy link
Collaborator

@aslonnie aslonnie commented Feb 3, 2025

so that when there is no deps change, it will just skip the test.

@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Feb 3, 2025
@aslonnie aslonnie force-pushed the lonnie-250203-cppcache branch from 5357b86 to 2c9dcef Compare February 3, 2025 22:04
.bazelrc Outdated Show resolved Hide resolved
@aslonnie aslonnie force-pushed the lonnie-250203-cppcache branch from 2c9dcef to 4b421a5 Compare February 4, 2025 13:52
@aslonnie aslonnie changed the title [core] cache test results for cpp builds [core] cache test results for cpp/cicd tests Feb 4, 2025
@aslonnie aslonnie force-pushed the lonnie-250203-cppcache branch from 4b421a5 to 5ffc990 Compare February 4, 2025 17:09
@aslonnie aslonnie added rllib-envrunners Issues around the sampling backend of RLlib and removed go add ONLY when ready to merge, run all tests rllib-envrunners Issues around the sampling backend of RLlib labels Feb 4, 2025
@aslonnie aslonnie requested a review from dentiny February 4, 2025 17:49
@aslonnie aslonnie force-pushed the lonnie-250203-cppcache branch from 5ffc990 to c70cefa Compare February 4, 2025 17:49
@aslonnie aslonnie requested a review from a team as a code owner February 4, 2025 17:49
@aslonnie aslonnie force-pushed the lonnie-250203-cppcache branch 4 times, most recently from 8de55c5 to 25327f8 Compare February 4, 2025 20:49
@aslonnie
Copy link
Collaborator Author

aslonnie commented Feb 4, 2025

test cache is working: https://buildkite.com/ray-project/postmerge/builds/8051#0194d2d2-4639-4745-935a-552166997904/176-1207

though it still takes quite some time to run.

@aslonnie aslonnie added go add ONLY when ready to merge, run all tests and removed go add ONLY when ready to merge, run all tests labels Feb 5, 2025
@aslonnie aslonnie force-pushed the lonnie-250203-cppcache branch 2 times, most recently from ff08e23 to defba62 Compare February 5, 2025 05:13
@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Feb 5, 2025
@aslonnie
Copy link
Collaborator Author

aslonnie commented Feb 5, 2025

ready for review.

@aslonnie aslonnie closed this Feb 5, 2025
@aslonnie aslonnie reopened this Feb 5, 2025
so that when there is no deps change, it will just skip the test.

Signed-off-by: Lonnie Liu <[email protected]>
@aslonnie aslonnie force-pushed the lonnie-250203-cppcache branch from defba62 to ad79baf Compare February 5, 2025 05:14
@aslonnie aslonnie requested a review from khluu February 5, 2025 05:17
@aslonnie aslonnie merged commit 6462f3e into master Feb 5, 2025
5 checks passed
@aslonnie aslonnie deleted the lonnie-250203-cppcache branch February 5, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants