[core] Add pipe redirection test #50206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentiny
force-pushed
the
hjiang/add-pipe-flush-test
branch
from
143b368 to
99998eb
Compare
dentiny
changed the title
dentiny
force-pushed
the
hjiang/add-pipe-flush-test
branch
from
99998eb to
3982e76
Compare
dentiny
changed the title
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/add-pipe-flush-test
branch
from
3982e76 to
89dd360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an addition test, which tests if we (1) don't write newliner to the stream; nor (2) close the pipe, if we could read whole content after a flush.