Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data][Part 1] Refactoring AllToAllOperator support of different shuffling strategies #50215

Merged
merged 17 commits into from
Feb 5, 2025

Conversation

alexeykudinkin
Copy link
Contributor

Why are these changes needed?

Refactoring AllToAllOperator support of different shuffling strategies to make it more manageable and extensible.

Changes

  • Rebased use_push_based_shuffle with shuffle_strategy param
  • Rebasing tests
  • Adding support to specify num_partitions into Dataset.groupby API
  • Tidying up

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@alexeykudinkin alexeykudinkin requested a review from a team as a code owner February 4, 2025 06:54
@alexeykudinkin alexeykudinkin added the go add ONLY when ready to merge, run all tests label Feb 4, 2025
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
@aslonnie aslonnie merged commit 296e7b7 into master Feb 5, 2025
5 checks passed
@aslonnie aslonnie deleted the ak/all-to-all-ref-1 branch February 5, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants