-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lint #50235
Fix lint #50235
Conversation
Signed-off-by: dentiny <[email protected]>
7860f63
to
d81220d
Compare
there is another PR trying to fix this: and that one touches even more files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you revert the release_logs/
files (and configure them to be excluded)? other file changes look good to me.
== Status == | ||
Memory usage on this node: 52.0/480.3 GiB | ||
Using FIFO scheduling algorithm. | ||
== Status == |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we keep these release_logs/
files untouched? I think these are copied from some particular output, and not really doc or source code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to get linter happy about it? Otherwise every time I push some changes I have to skip check...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we configure the lint to exclude these files?
hmm.. why is this closed? |
Changed made by linter: