Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint #50235

Closed
wants to merge 1 commit into from
Closed

Fix lint #50235

wants to merge 1 commit into from

Conversation

dentiny
Copy link
Contributor

@dentiny dentiny commented Feb 4, 2025

Changed made by linter:

ubuntu@hjiang-devbox-pg$ git push 
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing release/serve_tests/compute_tpl_gpu_node_gce.yaml
Fixing release/benchmarks/object_store/config.yaml
Fixing python/ray/serve/tests/test_config_files/duplicate_app_routes.yaml
Fixing release/serve_tests/compute_tpl_32_cpu_autoscaling_gce.yaml
Fixing release/benchmarks/single_node/config.yaml
Fixing python/ray/serve/tests/test_config_files/duplicate_app_names.yaml
Fixing release/release_logs/1.3.0/tune_tests/scalability_tests/test_xgboost_sweep.txt
Fixing .buildkite/llm.rayci.yml
Fixing release/nightly_tests/dataset/run_image_loader_microbenchmark.sh
Fixing doc/azure/azure-ray-template.json
Fixing rllib/tuned_examples/cql/hopper-cql.yaml
Fixing release/release_logs/0.8.2/microbenchmark.txt
Fixing release/release_logs/1.3.0/tune_tests/scalability_tests/test_result_throughput_single_node.txt
Fixing python/ray/autoscaler/_private/vsphere/ARCHITECTURE.md
Fixing rllib/tuned_examples/cql/halfcheetah-bc.yaml
Fixing release/ray_release/byod/requirements_debian_byod.txt
Fixing release/release_logs/0.8.6/stress_tests/test_many_tasks.txt
Fixing release/serve_tests/compute_tpl_32_cpu_gce.yaml
Fixing release/release_logs/1.2.0/scalability/distributed.txt
Fixing release/release_logs/1.0.1/rllib_regression.txt
Fixing rllib/tuned_examples/cql/hopper-bc.yaml
Fixing release/long_running_tests/README.rst
Fixing rllib/algorithms/sac/README.md
Fixing python/ray/autoscaler/gcp/example-tpu-pod-topology.yaml
Fixing ci/env/install-miniconda.sh

fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing release/release_logs/0.8.6/stress_tests/test_many_tasks.txt

Signed-off-by: dentiny <[email protected]>
@dentiny dentiny force-pushed the hjiang/fix-lint-feb-4 branch from 7860f63 to d81220d Compare February 4, 2025 23:53
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Feb 5, 2025
@aslonnie
Copy link
Collaborator

aslonnie commented Feb 5, 2025

there is another PR trying to fix this:
#50188

and that one touches even more files.

Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you revert the release_logs/ files (and configure them to be excluded)? other file changes look good to me.

== Status ==
Memory usage on this node: 52.0/480.3 GiB
Using FIFO scheduling algorithm.
== Status ==
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep these release_logs/ files untouched? I think these are copied from some particular output, and not really doc or source code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to get linter happy about it? Otherwise every time I push some changes I have to skip check...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we configure the lint to exclude these files?

@dentiny dentiny closed this Feb 5, 2025
@aslonnie
Copy link
Collaborator

aslonnie commented Feb 5, 2025

hmm.. why is this closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants